From daf6cc0c2e55f511be0ea0cc6c8bcd74dbc103bd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E6=9D=8E=E5=AD=90=E6=B5=A9?=
 <95196117+whiteswordLI@users.noreply.github.com>
Date: Wed, 24 Dec 2025 16:14:18 +0800
Subject: [PATCH] Apply suggestions from code review

fix some bugs in merge_lora

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---
 model/model_lora.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/model/model_lora.py b/model/model_lora.py
index 9fe8419..fa80012 100644
--- a/model/model_lora.py
+++ b/model/model_lora.py
@@ -47,12 +47,15 @@ def merge_lora(model, path):
     state_dict = {(k[7:] if k.startswith('module.') else k): v for k, v in state_dict.items()}
 
     for name, module in model.named_modules():
-        if isinstance(module, nn.Linear):
+        if isinstance(module, nn.Linear) and module.weight.shape[0] == module.weight.shape[1]:
             key_A = f"{name}.lora.A.weight"
             key_B = f"{name}.lora.B.weight"
             if key_A in state_dict and key_B in state_dict:
                 # 直接合并权重: W_new = W_old + B @ A
-                module.weight.data += state_dict[key_B] @ state_dict[key_A]
+                device = module.weight.device
+                A_weight = state_dict[key_A].to(device)
+                B_weight = state_dict[key_B].to(device)
+                module.weight.data += B_weight @ A_weight
                 
     return model